mapleFU commented on code in PR #45234: URL: https://github.com/apache/arrow/pull/45234#discussion_r1944432094
########## cpp/src/parquet/row_range.h: ########## @@ -0,0 +1,87 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <variant> +#include <vector> + +#include "parquet/platform.h" + +namespace parquet { + +/// RowRanges is a collection of non-overlapping and ascendingly ordered row ranges. +class PARQUET_EXPORT RowRanges { Review Comment: should we mark internal or experimental first? I think this might change fastly ########## cpp/src/parquet/row_range.h: ########## @@ -0,0 +1,87 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <variant> +#include <vector> + +#include "parquet/platform.h" + +namespace parquet { + +/// RowRanges is a collection of non-overlapping and ascendingly ordered row ranges. +class PARQUET_EXPORT RowRanges { + public: + /// \brief A range of contiguous rows represented by an interval. + struct IntervalRange { + /// Start row of the range (inclusive). + int64_t start; + /// End row of the range (inclusive). + int64_t end; + }; + + /// \brief A range of contiguous rows represented by a bitmap. + struct BitmapRange { + /// Start row of the range (inclusive). + int64_t offset; + /// Zero appended if there are less than 64 elements. + uint64_t bitmap; + }; + + /// \brief An end marker for the row range iterator. + struct End {}; + + /// \brief An iterator for accessing row ranges in order. + class Iterator { + public: + virtual ~Iterator() = default; + virtual std::variant<IntervalRange, BitmapRange, End> NextRange() = 0; Review Comment: Would this virtual function being slow? ########## cpp/src/parquet/row_range.cc: ########## @@ -0,0 +1,225 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "parquet/row_range.h" + +#include "arrow/util/bitmap_ops.h" +#include "arrow/util/unreachable.h" +#include "parquet/exception.h" + +namespace parquet { + +class IteratorImpl : public RowRanges::Iterator { + public: + explicit IteratorImpl(const RowRanges& ranges) + : iter_(ranges.ranges_.cbegin()), end_(ranges.ranges_.cend()) {} + + ~IteratorImpl() override = default; + + std::variant<RowRanges::IntervalRange, RowRanges::BitmapRange, RowRanges::End> + NextRange() override { + if (iter_ == end_) { + return RowRanges::End(); + } + if (std::holds_alternative<RowRanges::IntervalRange>(*iter_)) { + return std::get<RowRanges::IntervalRange>(*iter_); + } + if (std::holds_alternative<RowRanges::BitmapRange>(*iter_)) { + return std::get<RowRanges::BitmapRange>(*iter_); + } + arrow::Unreachable("Invalid row ranges type"); + } + + private: + decltype(RowRanges::ranges_.cbegin()) iter_; Review Comment: should we `using IterT = decltype(RowRanges::ranges_.cbegin());` here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
