mapleFU commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r1946034145
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2475,32 +2651,37 @@ std::shared_ptr<ColumnWriter>
ColumnWriter::Make(ColumnChunkMetaDataBuilder* met
encoding = properties->dictionary_index_encoding();
}
switch (descr->physical_type()) {
- case Type::BOOLEAN:
+ case Type::BOOLEAN: {
+ if (bloom_filter != nullptr) {
+ throw ParquetException("Bloom filter is not supported for boolean
type");
Review Comment:
Both lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]