jorisvandenbossche commented on code in PR #45425:
URL: https://github.com/apache/arrow/pull/45425#discussion_r1946102139
##########
python/pyarrow/util.py:
##########
@@ -230,6 +230,20 @@ def _break_traceback_cycle_from_frame(frame):
refs = frame = this_frame = None
+def download_urllib(url, out_path):
Review Comment:
```suggestion
def _download_urllib(url, out_path):
```
I would make those helpers private (the one below as well), since we let the
user directly call from `pyarrow.utils.<..>`
##########
python/pyarrow/tests/conftest.py:
##########
@@ -54,6 +54,16 @@
if tzdata_set_path:
set_timezone_db_path(tzdata_set_path)
+ # GH-45295: Try to populate TZDIR env var from tzdata package resource path
Review Comment:
What is the reason this is needed? (would maybe also be good to add a longer
comment about this)
Does ORC look for that env variable?
##########
ci/scripts/python_wheel_windows_test.bat:
##########
@@ -58,12 +58,5 @@ py -0p
@REM Validate wheel contents
%PYTHON_CMD% C:\arrow\ci\scripts\python_wheel_validate_contents.py --path
C:\arrow\python\repaired_wheels || exit /B 1
-@rem Download IANA Timezone Database for ORC C++
-curl https://cygwin.osuosl.org/noarch/release/tzdata/tzdata-2024a-1.tar.xz
--output tzdata.tar.xz || exit /B
-mkdir %USERPROFILE%\Downloads\test\tzdata
-arc unarchive tzdata.tar.xz %USERPROFILE%\Downloads\test\tzdata || exit /B
-set TZDIR=%USERPROFILE%\Downloads\test\tzdata\usr\share\zoneinfo
-dir %TZDIR%
Review Comment:
Don't we need to keep this? As you mentioned, this database is needed for
pyarrow (https://github.com/apache/arrow/pull/45425#issuecomment-2637775513),
so we should ideally have this for properly testing the wheel
(or do we use `download_tzdata_on_windows()` ourselves somewhere to do
this?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
