nealrichardson commented on a change in pull request #9797:
URL: https://github.com/apache/arrow/pull/9797#discussion_r600813505



##########
File path: r/README.md
##########
@@ -143,7 +143,15 @@ checkout:
 
 ``` shell
 cd ../../r
-R -e 'install.packages(c("devtools", "roxygen2", "pkgdown", "covr")); 
devtools::install_dev_deps()'
+
+R --vanilla << EOF
+options(repos = c(REPO_NAME = "https://cloud.r-project.org/";))

Review comment:
       ```suggestion
   options(repos = "https://cloud.r-project.org/";)
   ```

##########
File path: r/README.md
##########
@@ -143,7 +143,15 @@ checkout:
 
 ``` shell
 cd ../../r
-R -e 'install.packages(c("devtools", "roxygen2", "pkgdown", "covr")); 
devtools::install_dev_deps()'
+
+R --vanilla << EOF
+options(repos = c(REPO_NAME = "https://cloud.r-project.org/";))
+install.packages(c("bit64", "devtools", "roxygen2", "tidyselect",

Review comment:
       bit64 and tidyselect are hard dependencies of arrow so you don't need to 
install them explicitly
   
   None of the other dependencies are required to build the package, and they 
bring a lot of stuff with them, so it's probably better to leave them off as a 
separate step.
   
   The quickest version of this is `install.packages("remotes"); 
remotes::install_deps(dependencies = TRUE)`

##########
File path: r/README.md
##########
@@ -143,7 +143,15 @@ checkout:
 
 ``` shell
 cd ../../r
-R -e 'install.packages(c("devtools", "roxygen2", "pkgdown", "covr")); 
devtools::install_dev_deps()'
+
+R --vanilla << EOF

Review comment:
       I think it's also confusing; I'd go back to the one-liner, that wasn't 
the problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to