aweltsch commented on code in PR #7021:
URL: https://github.com/apache/arrow-rs/pull/7021#discussion_r1947493007
##########
arrow-cast/src/cast/decimal.rs:
##########
@@ -121,6 +169,40 @@ where
})
}
+pub(crate) fn convert_to_bigger_or_equal_scale_decimal_same_type<T>(
+ array: &PrimitiveArray<T>,
+ input_precision: u8,
+ input_scale: i8,
+ output_precision: u8,
+ output_scale: i8,
+ cast_options: &CastOptions,
+) -> Result<PrimitiveArray<T>, ArrowError>
+where
+ T: DecimalType,
+ T::Native: DecimalCast + ArrowNativeTypeOp,
+{
+ let delta_scale = output_scale - input_scale;
+ // if the gain in precision (digits) is greater than the multiplication
due to scaling
+ // every number will fit into the output type
+ let is_infallible_cast = (input_precision as i8) + delta_scale <=
(output_precision as i8);
Review Comment:
Good catch, I didn't find any place where this is validated before. We can
easily add a check at the top of the function to handle these case :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
