kou commented on code in PR #45468:
URL: https://github.com/apache/arrow/pull/45468#discussion_r1947546262
##########
c_glib/test/test-table.rb:
##########
@@ -274,6 +274,79 @@ def test_invalid
end
end
+=begin
+ sub_test_case("#validate_full") do
+ def setup
+ @id_field = Arrow::Field.new("id", Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("name", Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field, @name_field])
+
+ @id_array = build_uint_array([1])
+ @name_array = build_string_array(["abc"])
+ @arrays = [@id_array, @name_array]
+ end
+
+ def test_valid
+ table = Arrow::Table.new(@schema, @arrays)
+
+ assert do
+ table.validate
+ end
+ end
+
+ def test_invalid
+ message = "[table][validate]: Invalid: " +
+ "Column 1 named name expected length 1 but got length 2"
+
+ invalid_values = [@id_array, build_string_array(["abc", "def"])]
+ table = Arrow::Table.new(@schema, invalid_values)
+ assert_raise(Arrow::Error::Invalid.new(message)) do
+ table.validate
+ end
+ end
+ end
+=end
+
+ sub_test_case("#validate_full") do
+ def setup
+ @id_field = Arrow::Field.new("uint8", Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("string", Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field, @name_field])
+
+ @uint8_value = build_uint_array([1])
+ @valid_name_value = build_string_array(["abc"])
+
+ # U+3042 HIRAGANA LETTER A, U+3044 HIRAGANA LETTER I
+ data = "\u3042\u3044".b[0..-2]
+ value_offsets = Arrow::Buffer.new([0,data.size].pack("l*"))
+ @invalid_name_value = Arrow::StringArray.new(1,
Review Comment:
```suggestion
@invalid_name_values = Arrow::StringArray.new(1,
```
##########
c_glib/test/test-table.rb:
##########
@@ -274,6 +274,79 @@ def test_invalid
end
end
+=begin
+ sub_test_case("#validate_full") do
+ def setup
+ @id_field = Arrow::Field.new("id", Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("name", Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field, @name_field])
+
+ @id_array = build_uint_array([1])
+ @name_array = build_string_array(["abc"])
+ @arrays = [@id_array, @name_array]
+ end
+
+ def test_valid
+ table = Arrow::Table.new(@schema, @arrays)
+
+ assert do
+ table.validate
+ end
+ end
+
+ def test_invalid
+ message = "[table][validate]: Invalid: " +
+ "Column 1 named name expected length 1 but got length 2"
+
+ invalid_values = [@id_array, build_string_array(["abc", "def"])]
+ table = Arrow::Table.new(@schema, invalid_values)
+ assert_raise(Arrow::Error::Invalid.new(message)) do
+ table.validate
+ end
+ end
+ end
+=end
Review Comment:
Can we remove this?
##########
c_glib/test/test-table.rb:
##########
@@ -274,6 +274,79 @@ def test_invalid
end
end
+=begin
+ sub_test_case("#validate_full") do
+ def setup
+ @id_field = Arrow::Field.new("id", Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("name", Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field, @name_field])
+
+ @id_array = build_uint_array([1])
+ @name_array = build_string_array(["abc"])
+ @arrays = [@id_array, @name_array]
+ end
+
+ def test_valid
+ table = Arrow::Table.new(@schema, @arrays)
+
+ assert do
+ table.validate
+ end
+ end
+
+ def test_invalid
+ message = "[table][validate]: Invalid: " +
+ "Column 1 named name expected length 1 but got length 2"
+
+ invalid_values = [@id_array, build_string_array(["abc", "def"])]
+ table = Arrow::Table.new(@schema, invalid_values)
+ assert_raise(Arrow::Error::Invalid.new(message)) do
+ table.validate
+ end
+ end
+ end
+=end
+
+ sub_test_case("#validate_full") do
+ def setup
+ @id_field = Arrow::Field.new("uint8", Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("string", Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field, @name_field])
+
+ @uint8_value = build_uint_array([1])
+ @valid_name_value = build_string_array(["abc"])
+
+ # U+3042 HIRAGANA LETTER A, U+3044 HIRAGANA LETTER I
+ data = "\u3042\u3044".b[0..-2]
+ value_offsets = Arrow::Buffer.new([0,data.size].pack("l*"))
Review Comment:
Hmm. Our RuboCop configuration can't detect this...
```suggestion
value_offsets = Arrow::Buffer.new([0, data.size].pack("l*"))
```
##########
c_glib/test/test-table.rb:
##########
@@ -274,6 +274,79 @@ def test_invalid
end
end
+=begin
+ sub_test_case("#validate_full") do
+ def setup
+ @id_field = Arrow::Field.new("id", Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("name", Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field, @name_field])
+
+ @id_array = build_uint_array([1])
+ @name_array = build_string_array(["abc"])
+ @arrays = [@id_array, @name_array]
+ end
+
+ def test_valid
+ table = Arrow::Table.new(@schema, @arrays)
+
+ assert do
+ table.validate
+ end
+ end
+
+ def test_invalid
+ message = "[table][validate]: Invalid: " +
+ "Column 1 named name expected length 1 but got length 2"
+
+ invalid_values = [@id_array, build_string_array(["abc", "def"])]
+ table = Arrow::Table.new(@schema, invalid_values)
+ assert_raise(Arrow::Error::Invalid.new(message)) do
+ table.validate
+ end
+ end
+ end
+=end
+
+ sub_test_case("#validate_full") do
+ def setup
+ @id_field = Arrow::Field.new("uint8", Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("string", Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field, @name_field])
+
+ @uint8_value = build_uint_array([1])
+ @valid_name_value = build_string_array(["abc"])
Review Comment:
```suggestion
@id_values = build_uint_array([1])
@valid_name_values = build_string_array(["abc"])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
