CurtHagenlocher commented on PR #7098: URL: https://github.com/apache/arrow-rs/pull/7098#issuecomment-2645605250
> Changes make sense to me (though is a bit harder to identify where things might not have been added like tests, etc.) I'd gone through and searched the codebase for all instances of `Decimal128` and `Decimal256` and amended nearly all of them. For this subset of the changes, I think I got most of the non-benchmark tests. I was thinking there would be two more PRs, one to cover casts, changes to Parquet and CSV reader/writers, and benchmarks, and then one that does a final pass through the code to account for things that I originally missed due to the volume of changes and things that were added after I originally did this work in the end of December. > However, I think the addition of new values to `DataType` enum would make this a breaking change so would need to wait for next major release? Yes, it's definitely a breaking change. I have to admit that I'm not familiar with the arrow-rs release schedule. I'm used to the main branch of the primary Arrow repo which is always "Vnext". How does that work here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
