kou commented on code in PR #45470: URL: https://github.com/apache/arrow/pull/45470#discussion_r1948290478
########## dev/tasks/python-wheels/github.musllinux.yml: ########## Review Comment: What is the difference between `github.manylinux.yml` and `github.musllinux.yml`? Can we use the same `github.linux.yml`? ########## ci/docker/alpine-linux-3.18-verify-rc.dockerfile: ########## Review Comment: How about splitting this (adding support for running `dev/release/verify-release-candidate.sh` on Alpine Linux) as a follow-up task and removing from this PR? ########## ci/docker/python-wheel-musllinux.dockerfile: ########## @@ -0,0 +1,115 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +ARG base +FROM ${base} + +ARG arch +ARG arch_short +ARG musllinux + +ENV MUSLLINUX_VERSION=${musllinux} + +RUN apk update +RUN apk add --no-cache cmake flex wget zip + +# A system Python is required for ninja and vcpkg in this Dockerfile. +# On manylinux2014 base images, system Python is 2.7.5, while +# on manylinux_2_28, no system python is installed. +# We therefore override the PATH with Python 3.8 in /opt/python +# so that we have a consistent Python version across base images. +ENV CPYTHON_VERSION=cp39 +ENV PATH=/opt/python/${CPYTHON_VERSION}-${CPYTHON_VERSION}/bin:${PATH} + +# Install Ninja +ARG ninja=1.10.2 +COPY ci/scripts/install_ninja.sh arrow/ci/scripts/ +RUN /arrow/ci/scripts/install_ninja.sh ${ninja} /usr/local + +# Install ccache +ARG ccache=4.1 +COPY ci/scripts/install_ccache.sh arrow/ci/scripts/ +RUN /arrow/ci/scripts/install_ccache.sh ${ccache} /usr/local Review Comment: Can we install Ninja and ccache by `apk`? ########## ci/scripts/python_wheel_musllinux_build.sh: ########## Review Comment: Can we unify this to `ci/scripts/python_wheel_manylinux_build.sh`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
