kou commented on code in PR #594: URL: https://github.com/apache/arrow-java/pull/594#discussion_r1948510028
########## .github/pull_request_template.md: ########## @@ -0,0 +1,8 @@ +<!-- Thank you for opening a new pull request. --> Review Comment: I'm not sure whether comment in PR template works or not...: https://github.com/apache/arrow/issues/45485 ########## .github/pull_request_template.md: ########## @@ -0,0 +1,8 @@ +<!-- Thank you for opening a new pull request. --> +<!-- Please add one or more of these PR labels as appropriate: bug-fix, enhancement, documentation, dependencies, chore. --> +<!-- Please describe your changes: --> + +<!-- If there are breaking changes, please uncomment this line: --> +<!-- **This contains breaking changes.** --> + +<!-- Please link any issues with closing keywords, e.g. "Closes #NNN". -> Review Comment: ```suggestion Closes #NNN ``` ########## .github/pull_request_template.md: ########## @@ -0,0 +1,8 @@ +<!-- Thank you for opening a new pull request. --> +<!-- Please add one or more of these PR labels as appropriate: bug-fix, enhancement, documentation, dependencies, chore. --> +<!-- Please describe your changes: --> Review Comment: ```suggestion ### Your changes ``` ########## .github/pull_request_template.md: ########## @@ -0,0 +1,8 @@ +<!-- Thank you for opening a new pull request. --> +<!-- Please add one or more of these PR labels as appropriate: bug-fix, enhancement, documentation, dependencies, chore. --> +<!-- Please describe your changes: --> + +<!-- If there are breaking changes, please uncomment this line: --> +<!-- **This contains breaking changes.** --> Review Comment: How about removing this when there are no breaking changes? ```suggestion **This contains breaking changes.** (You can remove this if this PR doesn't have any breaking changes.) ``` ########## .github/pull_request_template.md: ########## @@ -0,0 +1,8 @@ +<!-- Thank you for opening a new pull request. --> +<!-- Please add one or more of these PR labels as appropriate: bug-fix, enhancement, documentation, dependencies, chore. --> Review Comment: How about adding a PR comment instead of this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
