zanmato1984 commented on PR #45268: URL: https://github.com/apache/arrow/pull/45268#issuecomment-2648653069
The race is that we didn't create synchronization for `aborted_` flag between `Abort` and `ExecuteTask`. I'm changing it to atomic variable to avoid the race (and moving it out from the critical sections protected by the `mutext_`). I assume the original design decision didn't forbid calling `Abort` during task execution (you can see that in the original code the `Abort` function checks if the task group state is `TaskGroupState::READY` which implies it already assumes a particular task groups is already started but not ran yet - but it could also be the case that it is running already). cc @pitrou @westonpace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
