pitrou commented on code in PR #45330:
URL: https://github.com/apache/arrow/pull/45330#discussion_r1950401531
##########
cpp/src/arrow/dataset/scanner.cc:
##########
@@ -318,10 +319,14 @@ Result<EnumeratedRecordBatchGenerator> FragmentToBatches(
RecordBatch::Make(options->dataset_schema, /*num_rows=*/0,
std::move(columns)));
auto enumerated_batch_gen = MakeEnumeratedGenerator(std::move(batch_gen));
- auto combine_fn =
- [fragment](const Enumerated<std::shared_ptr<RecordBatch>>& record_batch)
{
- return EnumeratedRecordBatch{record_batch, fragment};
- };
+ auto combine_fn = [fragment, cache_metadata = options->cache_metadata](
+ const Enumerated<std::shared_ptr<RecordBatch>>&
record_batch) {
+ if (!cache_metadata && record_batch.last) {
+ ARROW_WARN_NOT_OK(fragment.value->ClearCachedMetadata(),
+ "Could not clear cached metadata on fragment");
+ }
Review Comment:
That would certainly be nice but also more elaborate. I'll take a look at
the `MappedGenerator` implementation but generators are generally not easy to
reason about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
