pitrou commented on code in PR #45515:
URL: https://github.com/apache/arrow/pull/45515#discussion_r1957879289
##########
cpp/src/arrow/compute/key_map_internal.cc:
##########
@@ -297,8 +289,9 @@ uint64_t SwissTable::num_groups_for_resize() const {
}
}
-uint64_t SwissTable::wrap_global_slot_id(uint64_t global_slot_id) const {
- uint64_t global_slot_id_mask = (1 << (log_blocks_ + 3)) - 1;
+uint32_t SwissTable::wrap_global_slot_id(uint32_t global_slot_id) const {
+ uint32_t global_slot_id_mask =
+ static_cast<uint32_t>((1ULL << (log_blocks_ + kLogSlotsPerBlock)) -
1ULL);
Review Comment:
Ahah, ok. Thanks for the explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
