arashandishgar commented on issue #44615:
URL: https://github.com/apache/arrow/issues/44615#issuecomment-2662917258
the warning for include-what-you-use for scalar_string_ascii.cc is
```
IWYU_SH match arrow/compute/kernels/scalar_string_ascii.cc
include-what-you-use 0.18 (git:abd5d2b) based on Ubuntu clang version 14.0.6
Running IWYU on
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc
should add these lines:
#include <re2/stringpiece.h> // for StringPiece
#include <cstring> // for memcpy
#include <functional> // for function
#include <limits> // for
numeric_li...
#include <map> // for operator==
#include <variant> // for variant
#include "arrow/array/array_base.h" // for Array
#include "arrow/array/builder_base.h" // for MakeBuilder
#include "arrow/array/util.h" // for
MakeArrayO...
#include "arrow/buffer_builder.h" // for
TypedBuffe...
#include "arrow/compute/api_scalar.h" // for
MatchSubst...
#include "arrow/compute/exec.h" // for ExecSpan
#include "arrow/compute/kernels/common_internal.h" // for vector
#include "arrow/scalar.h" // for
BaseBinary...
#include "arrow/util/bit_block_counter.h" // for
`VisitBitBl...`
#include "arrow/util/bit_util.h" // for GetBit
#include "arrow/util/bitmap_writer.h" // for
FirstTimeB...
#include "arrow/visit_data_inline.h" // for
VisitArray...
namespace arrow { namespace compute { class FunctionOptions; } }
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc
should remove these lines:
- #include <cctype> // lines 19-19
- #include <memory> // lines 21-21
- #include <string> // lines 22-22
- #include "arrow/util/macros.h" // lines 29-29
- #include "arrow/util/value_parsing.h" // lines 31-31
```
and for `api_scalar.cc` is
```
include-what-you-use 0.18 (git:abd5d2b) based on Ubuntu clang version 14.0.6
Running IWYU on
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/compute/api_scalar.cc
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/compute/api_scalar.h
should add these lines:
#include <cstdint> // for int64_t, int8_t, uint64_t
#include <limits> // for numeric_limits
#include <memory> // for shared_ptr
#include <vector> // for vector, initializer_list
#include "arrow/type.h" // for FieldRef, TimeUnit,
Time...
namespace arrow { class KeyValueMetadata; }
namespace arrow { namespace compute { class ExecContext; } }
namespace arrow { struct Scalar; }
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/compute/api_scalar.h
should remove these lines:
- #include <utility> // lines 25-25
- #include "arrow/compute/type_fwd.h" // lines 28-28
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/compute/api_scalar.cc
should add these lines:
#include <algorithm> // for max
#include <array> // for array
#include <utility> // for move
#include <variant> // for variant
#include "arrow/scalar.h" // for DoubleScalar, NullScalar
#include "arrow/util/compare.h" // for operator==
#include "arrow/util/reflection_internal.h" // for DataMember,
BasicEnumTr...
namespace arrow { class KeyValueMetadata; }
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/compute/api_scalar.cc
should remove these lines:
- #include <sstream> // lines 22-22
- #include "arrow/array/array_base.h" // lines 25-25
- #include "arrow/status.h" // lines 29-29
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
