friendlymatthew commented on code in PR #7141:
URL: https://github.com/apache/arrow-rs/pull/7141#discussion_r1958792700
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -5217,6 +5228,374 @@ mod tests {
}};
}
+ #[test]
+ fn test_cast_date32_to_timestamp_with_timezone() {
+ let tz = "+0545"; // UTC + 0545 is Asia/Kathmandu
+ let a = Date32Array::from(vec![Some(18628), Some(18993), None]); //
2021-1-1, 2022-1-1
Review Comment:
> So the default tz of date is UTC, right?
Yes, but shouldn't we ensure `Date`s cast to timestamps with a particular
timezone?
I'm also a bit confused by this comment. Are you implying that `a` is
improperly constructed? (i.e. the third element shouldn't be `None`?) Here's a
similar test case that tests for time zone aware timestamps:
https://github.com/apache/arrow-rs/blob/38d6e691f4ee1b356f28d77b6820de67166c51c3/arrow-cast/src/cast/mod.rs#L5277-L5291
Maybe I'm misunderstanding something. Would appreciate some clarification.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
