james-rms opened a new pull request, #7147:
URL: https://github.com/apache/arrow-rs/pull/7147
# Which issue does this PR close?
TBD
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
Right now the `object_store` crate can't read an object in GCS with name
`[foo]`.
`GCSObjectStore::get(&Path::from("[foo]")` will see the object name percent
encoded once in `PathPart::from`, then again in `GcsObjectStore::object_url`,
and the resulting request URL will be double-encoded `%255Bfoo%255D` instead of
`%5Bfoo%5D`.
This double-encoding seems like a bug to me. It probably doesn't affect
clients who exclusively use the `object_store` crate (since the double encoding
happens on read and write) but for those operating across multiple stores, this
is a serious issue.
Fixing this bug will introduce a backwards-compatibility issue for users who
have written double-encoded object paths into GCS using `object_store`. If this
is not acceptable, I can add an option into the client and client builder to
enable or disable this behavior.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
