waynr commented on code in PR #7152:
URL: https://github.com/apache/arrow-rs/pull/7152#discussion_r1962352629
##########
object_store/src/lib.rs:
##########
@@ -916,7 +916,7 @@ pub struct ObjectMeta {
}
/// Options for a get request, such as range
-#[derive(Debug, Default, Clone)]
+#[derive(Debug, Default, Clone, PartialEq, Eq)]
pub struct GetOptions {
Review Comment:
`Eq` and `PartialEq` aren't dyn-compatible because they take `Self` as a
type parameter:
https://doc.rust-lang.org/error_codes/E0038.html#trait-uses-self-as-a-type-parameter-in-the-supertrait-listing
We could work around that with custom `PartialEq` and `Eq` implementations
that ignore the extensions field discussed in
https://github.com/apache/arrow-rs/issues/7155 (opened in favor of
https://github.com/apache/arrow-rs/issues/7135). Given that the extensions are
meant to be used by custom `ObjectStore` implementations/wrappers and ignored
by the builtin backends this shouldn't be a problem, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
