WillAyd commented on code in PR #45596:
URL: https://github.com/apache/arrow/pull/45596#discussion_r1964262214
##########
cpp/src/arrow/meson.build:
##########
@@ -289,6 +373,49 @@ install_headers(
install_dir: 'arrow',
)
+if needs_tests
+ filesystem_dep = dependency('boost', modules: ['filesystem'])
+ gtest_main_dep = dependency('gtest_main')
+ gmock_dep = dependency('gmock')
+else
+ filesystem_dep = disabler()
+ gtest_main_dep = disabler()
+ gmock_dep = disabler()
+endif
+
+arrow_test_lib = static_library(
Review Comment:
The static_library is required here because the Meson wrap dependency for
gtest only provides consumers with the source files, and when using that in two
different shared libraries then linking together you get an ODR violation.
See also https://github.com/mesonbuild/wrapdb/issues/1937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
