davidhcoe commented on code in PR #2540: URL: https://github.com/apache/arrow-adbc/pull/2540#discussion_r1963789863
########## csharp/src/Drivers/Apache/Hive2/HiveServer2AuthType.cs: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache.Arrow.Adbc.Drivers.Apache.Hive2 +{ + internal enum HiveServer2AuthType + { + Invalid = 0, Review Comment: Are there tests for each of these types? ########## csharp/src/Drivers/Apache/Hive2/HiveServer2Reader.cs: ########## @@ -73,11 +75,13 @@ internal class HiveServer2Reader : IArrowArrayStream public HiveServer2Reader( HiveServer2Statement statement, Schema schema, - DataTypeConversion dataTypeConversion) + DataTypeConversion dataTypeConversion, + bool enableBatchSizeStopCondition = false) Review Comment: Since this is an internal class, and all of our calls to this seem to set the value to true, should there be a parameter that lets the caller set the value if they wish? ########## csharp/src/Drivers/Apache/Hive2/HiveServer2Type.cs: ########## @@ -0,0 +1,48 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +namespace Apache.Arrow.Adbc.Drivers.Apache.Hive2 +{ + internal enum HiveServer2Type + { + Invalid = 0, Review Comment: for my own knowledge, why are Invalid or Empty even options if they just fail when someone passes them? ########## csharp/test/Drivers/Apache/Common/DriverTests.cs: ########## @@ -385,6 +385,7 @@ public void CanGetObjectsAll() { // Verify column metadata is returned/consistent. AdbcColumn column = columns[i]; + // TODO: Fix ordinal position for Hive. Review Comment: does the TODO mean this will fail? Or what happens in the current state if it's not fixed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
