tustvold commented on PR #7159: URL: https://github.com/apache/arrow-rs/pull/7159#issuecomment-2674011556
> Yes, should divide by zero be considered as overflow? At the very least it shouldn't panic :sweat_smile: I personally feel it would be better to simply document that `fail_on_overflow` doesn't impact division operators. It seems a pretty tough pill to effectively double the codegen in order to handle a single set of arguments that overflows.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
