arashandishgar commented on code in PR #45577:
URL: https://github.com/apache/arrow/pull/45577#discussion_r1969954741
##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -1958,6 +1960,29 @@ TYPED_TEST(TestBaseBinaryKernels, ExtractRegex) {
R"([{"letter": "a", "digit": "1"}, {"letter": "b", "digit":
"3"}])",
&options);
}
+TYPED_TEST(TestBaseBinaryKernels, ExtractRegexSapn) {
+ ExtractRegexSpanOptions options{"(?P<letter>[ab])(?P<digit>\\d)"};
Review Comment:
could you elaborate what do you mean ?Actually, I see the similar behaviour
in arrow(remember that the entire extract_regex computation is on the re2),.
```
ExtractRegexSpanOptions options{"(?P<foo>foo)?(?P<digit>\\d+)?"};
this->CheckUnary("extract_regex_span", R"(["abcfoo"])",
out_type,
R"([{"foo":null,"digit":null}])",
&options);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
