WillAyd commented on code in PR #710:
URL: https://github.com/apache/arrow-nanoarrow/pull/710#discussion_r1970588033
##########
src/nanoarrow/common/array.c:
##########
@@ -1157,9 +1175,31 @@ static int ArrowArrayViewValidateDefault(struct
ArrowArrayView* array_view,
return EINVAL;
}
}
+
+ if ((array_view->storage_type == NANOARROW_TYPE_LIST_VIEW) &&
Review Comment:
I might be misunderstanding. To clarify further what I was thinking, lists
and strings check the first/last `offset` in default validation, but have no
size checking, given they do not have a dedicated size buffer. The list view
repeats that same check for the `offset` buffer and extends it over to the
`size` buffer.
So do you want to keep the first/last check of offsets for the list view in
the default validation and move the size check to full validation? Or should we
eliminate the size check altogether?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
