pitrou commented on PR #45622:
URL: https://github.com/apache/arrow/pull/45622#issuecomment-2687580493
Hmm, I really don't like the new `BinaryBuilder` API that this is adding.
Perhaps we should instead add these APIs and let Parquet use those builders?
```diff
diff --git a/cpp/src/arrow/array/builder_binary.h
b/cpp/src/arrow/array/builder_binary.h
index 442e4a2632..e568279508 100644
--- a/cpp/src/arrow/array/builder_binary.h
+++ b/cpp/src/arrow/array/builder_binary.h
@@ -359,6 +359,9 @@ class BaseBinaryBuilder
/// \return data pointer of the value date builder
const offset_type* offsets_data() const { return offsets_builder_.data();
}
+ TypedBufferBuilder<offset_type>* offsets_builder() { return
&offsets_builder_; }
+ TypedBufferBuilder<uint8_t>* value_data_builder() { return
&value_data_builder_; }
+
/// Temporary access to a value.
///
/// This pointer becomes invalid on the next modifying operation.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
