paleolimbot commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r1975909959
##########
cpp/src/parquet/types.h:
##########
@@ -166,6 +168,17 @@ class PARQUET_EXPORT LogicalType {
enum unit { UNKNOWN = 0, MILLIS = 1, MICROS, NANOS };
};
+ struct EdgeInterpolationAlgorithm {
+ enum algorithm {
Review Comment:
I changed this to an enum class (although I think it looks a little funny
next to in the header `TimeUnit::unit`). It may be worth updating this for all
of these enums at some point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]