chilin0525 commented on issue #45619: URL: https://github.com/apache/arrow/issues/45619#issuecomment-2692109777
Hi @kou , I'm still working on the PR to refactor all instances of string.format. However, in some cases, I'm unsure whether they should also be refactored. For example, in the following case, `string.format` allows passing parameters, making the code more reusable. In such scenarios, f-strings may not be as convenient. Given this, do you think we should still replace them with f-strings, or should we leave them as they are? Thanks https://github.com/apache/arrow/blob/0fbf9823542233c5f32c26534c34cc97ce3f0be2/python/pyarrow/parquet/core.py#L1624-L1695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
