paleolimbot commented on code in PR #45459: URL: https://github.com/apache/arrow/pull/45459#discussion_r1975902982
########## cpp/src/parquet/test_util.h: ########## @@ -830,5 +833,124 @@ inline void GenerateData<FLBA>(int num_values, FLBA* out, std::vector<uint8_t>* random_fixed_byte_array(num_values, 0, heap->data(), kGenerateDataFLBALength, out); } +// ---------------------------------------------------------------------- +// Test utility functions for geometry + +#if defined(ARROW_LITTLE_ENDIAN) +static constexpr uint8_t kWkbNativeEndianness = 0x01; +#else +static constexpr uint8_t kWkbNativeEndianness = 0x00; +#endif + +static uint32_t GeometryTypeToWKB(geometry::GeometryType geometry_type, bool has_z, Review Comment: I think I successfully removed anything from test_util.h that wasn't used in a a test! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
