zanmato1984 commented on code in PR #45421:
URL: https://github.com/apache/arrow/pull/45421#discussion_r1978696787
##########
cpp/src/arrow/acero/concurrent_queue_internal.h:
##########
@@ -133,7 +144,14 @@ class BackpressureConcurrentQueue : public
ConcurrentQueue<T> {
T Pop() {
std::unique_lock<std::mutex> lock(ConcurrentQueue<T>::GetMutex());
DoHandle do_handle(*this);
- return ConcurrentQueue<T>::PopUnlocked();
+ return ConcurrentQueue<T>::PopUnlocked(lock);
Review Comment:
I'm afraid this should a compiler error, but omitted due to uninstantiated
method in template class. I'll fix this (after instantiating it in test cases)
in my commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
