rluvaton commented on PR #7211: URL: https://github.com/apache/arrow-rs/pull/7211#issuecomment-2703709894
These are the results: ``` Running benches/take_kernels.rs (target/release/deps/take_kernels-6c28723f8254672e) take i32 512 time: [228.39 ns 228.91 ns 229.40 ns] change: [-0.5343% -0.2657% -0.0186%] (p = 0.05 < 0.05) Change within noise threshold. Found 4 outliers among 100 measurements (4.00%) 4 (4.00%) high mild take i32 1024 time: [367.72 ns 368.26 ns 368.85 ns] change: [-0.2321% +0.0847% +0.3772%] (p = 0.59 > 0.05) No change in performance detected. Found 7 outliers among 100 measurements (7.00%) 5 (5.00%) high mild 2 (2.00%) high severe take i32 null indices 1024 time: [402.29 ns 402.74 ns 403.24 ns] change: [-0.4594% -0.1925% +0.0638%] (p = 0.16 > 0.05) No change in performance detected. Found 10 outliers among 100 measurements (10.00%) 4 (4.00%) low mild 5 (5.00%) high mild 1 (1.00%) high severe take i32 null values 1024 time: [1.1230 µs 1.1238 µs 1.1248 µs] change: [-0.0951% +0.1274% +0.4030%] (p = 0.34 > 0.05) No change in performance detected. Found 9 outliers among 100 measurements (9.00%) 2 (2.00%) low mild 2 (2.00%) high mild 5 (5.00%) high severe take i32 null values null indices 1024 time: [1.4981 µs 1.5005 µs 1.5030 µs] change: [+3.0213% +3.4346% +3.8211%] (p = 0.00 < 0.05) Performance has regressed. Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high severe take check bounds i32 512 time: [384.73 ns 387.07 ns 389.51 ns] change: [-6.8232% -6.0607% -5.2852%] (p = 0.00 < 0.05) Performance has improved. Found 14 outliers among 100 measurements (14.00%) 1 (1.00%) low mild 3 (3.00%) high mild 10 (10.00%) high severe take check bounds i32 1024 time: [659.63 ns 660.57 ns 661.59 ns] change: [-11.029% -10.131% -9.2208%] (p = 0.00 < 0.05) Performance has improved. Found 3 outliers among 100 measurements (3.00%) 2 (2.00%) low mild 1 (1.00%) high mild take bool 512 time: [432.99 ns 433.49 ns 434.02 ns] change: [-12.467% -11.796% -11.069%] (p = 0.00 < 0.05) Performance has improved. Found 3 outliers among 100 measurements (3.00%) 1 (1.00%) high mild 2 (2.00%) high severe take bool 1024 time: [760.41 ns 762.71 ns 765.27 ns] change: [-10.699% -9.8706% -9.0400%] (p = 0.00 < 0.05) Performance has improved. Found 6 outliers among 100 measurements (6.00%) 5 (5.00%) high mild 1 (1.00%) high severe take bool null indices 1024 time: [1.0365 µs 1.0389 µs 1.0414 µs] change: [-13.459% -12.879% -12.268%] (p = 0.00 < 0.05) Performance has improved. Found 3 outliers among 100 measurements (3.00%) 3 (3.00%) high mild take bool null values 1024 time: [1.4908 µs 1.4951 µs 1.4997 µs] change: [-11.797% -11.035% -10.248%] (p = 0.00 < 0.05) Performance has improved. Found 12 outliers among 100 measurements (12.00%) 1 (1.00%) low severe 6 (6.00%) high mild 5 (5.00%) high severe take bool null values null indices 1024 time: [2.3190 µs 2.3274 µs 2.3371 µs] change: [-5.8016% -4.7611% -3.6806%] (p = 0.00 < 0.05) Performance has improved. Found 13 outliers among 100 measurements (13.00%) 6 (6.00%) high mild 7 (7.00%) high severe take str 512 time: [6.4061 µs 6.8353 µs 7.3023 µs] change: [-4.4016% +3.0168% +11.015%] (p = 0.44 > 0.05) No change in performance detected. take str 1024 time: [17.311 µs 17.643 µs 17.978 µs] change: [-1.2489% +2.6694% +6.3646%] (p = 0.17 > 0.05) No change in performance detected. Found 14 outliers among 100 measurements (14.00%) 7 (7.00%) low severe 5 (5.00%) low mild 2 (2.00%) high mild take str null indices 512 time: [3.0301 µs 3.0405 µs 3.0516 µs] change: [-1.4806% -1.0591% -0.6077%] (p = 0.00 < 0.05) Change within noise threshold. Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high mild take str null indices 1024 time: [11.907 µs 12.548 µs 13.151 µs] change: [+7.0323% +11.177% +15.693%] (p = 0.00 < 0.05) Performance has regressed. Found 15 outliers among 100 measurements (15.00%) 9 (9.00%) low severe 2 (2.00%) low mild 4 (4.00%) high mild take str null values 1024 time: [6.7674 µs 7.0861 µs 7.4755 µs] change: [-18.621% -13.649% -8.2377%] (p = 0.00 < 0.05) Performance has improved. Found 12 outliers among 100 measurements (12.00%) 4 (4.00%) high mild 8 (8.00%) high severe take str null values null indices 1024 time: [4.0659 µs 4.0753 µs 4.0847 µs] change: [-1.1853% -0.8649% -0.5550%] (p = 0.00 < 0.05) Change within noise threshold. Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high mild take stringview 512 time: [296.37 ns 297.30 ns 298.30 ns] change: [+0.2149% +0.6568% +1.0725%] (p = 0.00 < 0.05) Change within noise threshold. Found 2 outliers among 100 measurements (2.00%) 1 (1.00%) high mild 1 (1.00%) high severe take stringview 1024 time: [506.67 ns 508.49 ns 510.45 ns] change: [-0.4648% +0.2074% +0.9322%] (p = 0.59 > 0.05) No change in performance detected. Found 6 outliers among 100 measurements (6.00%) 2 (2.00%) high mild 4 (4.00%) high severe take stringview null indices 512 time: [352.83 ns 359.88 ns 367.00 ns] change: [-4.1128% +0.6596% +5.4257%] (p = 0.78 > 0.05) No change in performance detected. Found 7 outliers among 100 measurements (7.00%) 4 (4.00%) high mild 3 (3.00%) high severe take stringview null indices 1024 time: [879.16 ns 909.23 ns 939.45 ns] change: [-1.4138% +2.5376% +6.7625%] (p = 0.21 > 0.05) No change in performance detected. take stringview null values 1024 time: [1.2426 µs 1.2450 µs 1.2476 µs] change: [-0.5604% -0.2909% -0.0404%] (p = 0.03 < 0.05) Change within noise threshold. Found 5 outliers among 100 measurements (5.00%) 5 (5.00%) high mild take stringview null values null indices 1024 time: [2.0488 µs 2.0811 µs 2.1112 µs] change: [-6.0607% -4.2672% -2.4231%] (p = 0.00 < 0.05) Performance has improved. take primitive run logical len: 1024, physical len: 512, indices: 1024 time: [11.722 µs 11.739 µs 11.758 µs] change: [-0.9660% -0.6648% -0.4017%] (p = 0.00 < 0.05) Change within noise threshold. Found 11 outliers among 100 measurements (11.00%) 3 (3.00%) low severe 2 (2.00%) low mild 3 (3.00%) high mild 3 (3.00%) high severe ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org