kszucs commented on code in PR #45688:
URL: https://github.com/apache/arrow/pull/45688#discussion_r1983576419
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1209,28 +1209,31 @@ Status ConvertDictionaryToDense(const ::arrow::Array&
array, MemoryPool* pool,
return Status::OK();
}
-template <typename DType>
-class TypedColumnWriterImpl : public ColumnWriterImpl, public
TypedColumnWriter<DType> {
+template <typename ParquetType>
Review Comment:
Since the implementation uses both parquet and arrow types, I thought it is
better to be explicit. I can restore the previous name though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
