EnricoMi commented on code in PR #44470: URL: https://github.com/apache/arrow/pull/44470#discussion_r1984731751
########## python/pyarrow/dataset.py: ########## @@ -848,9 +848,9 @@ def _ensure_write_partitioning(part, schema, flavor): def write_dataset(data, base_dir, *, basename_template=None, format=None, - partitioning=None, partitioning_flavor=None, schema=None, - filesystem=None, file_options=None, use_threads=True, Review Comment: This is not a breaking change as it is a keyword parameter. All parameters after `*` are named on call-site. So the position can change without breaking user code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
