mbutrovich commented on PR #7250: URL: https://github.com/apache/arrow-rs/pull/7250#issuecomment-2707190308
This is my first contribution to this repo and I'm still getting comfortable with Rust, and I have a number of thoughts after working on this that I'll list below: - https://github.com/apache/arrow-rs/blob/5b04ca7bf756c5ca9edfba220060017684e2ecc6/parquet/src/data_type.rs#L548 `AsSliceBytes` would be nice for the `IntoBuffer` change I made. Where could I read more on if type alignment concerns could be addressed to support `AsSliceBytes` for `Int96`? - https://github.com/apache/arrow-rs/blob/b62ab3b905cb2811447e7ad0a1c22da1e478b00f/parquet/src/arrow/schema/primitive.rs#L57 This change is saying that `FSB(12)` is an acceptable hint for `TS(Nano)`. However, we really only want that if the `TS(Nano)` originated from an INT96. How should I make this more bulletproof? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
