rok commented on code in PR #6637:
URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1985961494
##########
parquet/src/arrow/async_reader/metadata.rs:
##########
@@ -127,13 +128,26 @@ impl<F: MetadataFetch> MetadataLoader<F> {
let (metadata, remainder) = if length > suffix_len - FOOTER_SIZE {
let metadata_start = file_size - length - FOOTER_SIZE;
let meta = fetch.fetch(metadata_start..file_size -
FOOTER_SIZE).await?;
- (ParquetMetaDataReader::decode_metadata(&meta)?, None)
+ (
+ ParquetMetaDataReader::decode_metadata(
Review Comment:
I've changed the proposal so it now no longer changes the API, however quite
some `#cfg(...)`s are still needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
