zeroshade commented on code in PR #2589:
URL: https://github.com/apache/arrow-adbc/pull/2589#discussion_r1987943090
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -338,9 +338,20 @@ def commit(self) -> None:
if self._commit_supported:
self._conn.commit()
- def cursor(self) -> "Cursor":
- """Create a new cursor for querying the database."""
- return Cursor(self)
+ def cursor(
+ self,
+ *,
+ adbc_stmt_kwargs: Optional[Dict[str, Any]] = None,
+ ) -> "Cursor":
+ """
+ Create a new cursor for querying the database.
+
+ Parameters
+ ----------
+ adbc_stmt_kwargs : dict, optional
+ ADBC-specific options to pass to the underlying ADBC statement.
+ """
+ return Cursor(self, adbc_stmt_kwargs)
Review Comment:
should this be `**adbc_stmt_kwargs`? Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
