kou commented on code in PR #45706:
URL: https://github.com/apache/arrow/pull/45706#discussion_r1988050893
##########
python/pyarrow/_azurefs.pyx:
##########
@@ -100,6 +105,9 @@ cdef class AzureFileSystem(FileSystem):
if account_key:
options.ConfigureAccountKeyCredential(tobytes(account_key))
self.account_key = tobytes(account_key)
+ elif sas_token:
+ options.ConfigureSASCredential(tobytes(sas_token))
+ self.sas_token = tobytes(sas_token)
Review Comment:
Then should we use `if sas_token: elif account_key:`?
Or should we raise an error when both of `sas_token` and `account_key` are
specified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
