adriangb commented on PR #7015: URL: https://github.com/apache/arrow-rs/pull/7015#issuecomment-2712204581
> I think the changes make the null handling worse 😅 > > The API was designed the way it was for a reason, I think if we want to change it we need to justify doing so empirically To be clear, you're saying that the API `make_encoder(...) -> (Box<dyn Encoder>, NullBuffer)` is a better API than adding a `nulls()` method to `Encoder` to package them up together? Or is it something else about the existing implementation that I'm missing? I can try to revert it if that's it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
