assignUser commented on code in PR #719:
URL: https://github.com/apache/arrow-nanoarrow/pull/719#discussion_r1992078052
##########
CMakeLists.txt:
##########
@@ -416,6 +452,13 @@ foreach(target
# Ensure NANOARROW_DEBUG is defined for debug builds
target_compile_definitions(${target} PUBLIC
"$<$<CONFIG:Debug>:NANOARROW_DEBUG>")
+ # Ensure NANOARROW_DLL is set when building and linking to the library
+ if(target MATCHES "_shared$")
Review Comment:
Targets have a `TYPE` property that you could check here instead of the
name: https://cmake.org/cmake/help/latest/prop_tgt/TYPE.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
