amoeba commented on code in PR #45685:
URL: https://github.com/apache/arrow/pull/45685#discussion_r1992134420


##########
r/tests/testthat/test-dataset.R:
##########
@@ -915,7 +915,7 @@ test_that("Dataset and query print methods", {
       "dbl: double",
       "lgl: bool",
       "chr: string",
-      "fct: dictionary<values=string, indices=int32>",
+      "fct: dictionary<values=string, indices=int8>",

Review Comment:
   I pushed up a slightly tweaked version of the above in 
https://github.com/apache/arrow/pull/45685/commits/89a424d6235441687abd9e65938cc9a710eece72
 and it passes for me against dev and from 19.0.1.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to