alamb commented on PR #7200:
URL: https://github.com/apache/arrow-rs/pull/7200#issuecomment-2719077139

   Hi @psvri  -- thank you for this contribution
   
   I noticed that this PR reports benchmark numbers. What benchmark were these? 
Are they from zilb-rs? 
   
   Did you run any benchmarks for the parquet crate itself (as in from the 
https://github.com/apache/arrow-rs/tree/main/parquet/benches directory)?
   
   ```
   Benchmarking compress GZIP(GzipLevel(6)) - alphanumeric: Collecting 100 
samples in estimated 5.0406 s (200 itercompress GZIP(GzipLevel(6)) - 
alphanumeric
                           time:   [24.395 ms 24.934 ms 25.612 ms]
                           change: [-33.807% -31.734% -29.276%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 4 outliers among 100 measurements (4.00%)
     1 (1.00%) high mild
     3 (3.00%) high severe
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to