alamb opened a new pull request, #7277: URL: https://github.com/apache/arrow-rs/pull/7277
# Which issue does this PR close? - reverts https://github.com/apache/arrow-rs/pull/7266 / commit f4fde769ab6e1a9b75f890b7f8b47bc22800830b. # Rationale for this change - This is the same code as in https://github.com/apache/arrow-rs/pull/7229 from @XiangpengHao that contains a breaking API change - Unfortunately we accidentally merged it and had to revert in https://github.com/apache/arrow-rs/pull/7266 # Rationale for the original change (from @XiangpengHao): When working on the nightly rust, I noticed that clippy warns about `FlightError` too large, more than 176 bytes. I think it makes sense to keep the error small (32 bytes), as the Result<...> is used in a lot of places. This PR basically makes `Tonic(tonic::Status)` into `Tonic(Box<tonic::Status>)`, which reduces the FlightError from 176 bytes down to 32 bytes. This adds an extra allocation on error, but should probably be fine as it's not on hot path. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please call them out. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
