kou commented on code in PR #45695:
URL: https://github.com/apache/arrow/pull/45695#discussion_r1992510090


##########
cpp/src/gandiva/encrypt_utils_test.cc:
##########
@@ -20,36 +20,40 @@
 #include <gtest/gtest.h>
 
 TEST(TestShaEncryptUtils, TestAesEncryptDecrypt) {
-  // 8 bytes key
-  auto* key = "1234abcd";

Review Comment:
   OK. Could you add the "This PR includes breaking changes to public APIs. (If 
there are any breaking changes to public APIs, please explain which changes are 
breaking. If not, you can remove this.)" part in the pull request template to 
the PR description?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to