rok commented on code in PR #7279: URL: https://github.com/apache/arrow-rs/pull/7279#discussion_r1992544852
########## parquet/tests/arrow_reader/mod.rs: ########## @@ -38,6 +38,15 @@ use tempfile::NamedTempFile; mod bad_data; #[cfg(feature = "crc")] mod checksum; +#[cfg(feature = "encryption")] +mod encryption; +#[cfg(all(feature = "encryption", feature = "async"))] +mod encryption_async; +mod encryption_common; Review Comment: Nit: how about `read_encrypted_with_plaintext_footer` or `encryption_agnostic`? `encryption_common` slightly implies some sort of shared utility and made me wonder why it's not behind `#[cfg(feature = "encryption")]`. Not a big deal, feel free to ignore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
