CurtHagenlocher commented on code in PR #45753:
URL: https://github.com/apache/arrow/pull/45753#discussion_r1993460921
##########
csharp/src/Apache.Arrow.Flight/FlightInfo.cs:
##########
@@ -38,15 +38,19 @@ internal FlightInfo(Protocol.FlightInfo flightInfo)
TotalBytes = flightInfo.TotalBytes;
TotalRecords = flightInfo.TotalRecords;
+ Ordered = flightInfo.Ordered;
+ AppMetadata = flightInfo.AppMetadata;
}
- public FlightInfo(Schema schema, FlightDescriptor descriptor,
IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long
totalBytes = -1)
+ public FlightInfo(Schema schema, FlightDescriptor descriptor,
IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long
totalBytes = -1, bool ordered = false, ByteString appMetadata=null)
Review Comment:
This breaks binary compatibility, and there are scenarios where that
matters. Could you add an overload with the additional parameters instead of
changing the existing public constructor? The original constructor can chain to
the new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
