mbutrovich opened a new pull request, #7285: URL: https://github.com/apache/arrow-rs/pull/7285
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Partially addresses #7220. Brings behavior similar to arrow-cpp: https://github.com/apache/arrow/blob/6b66c842eefec520d391203d205cd91d1ca0dd65/cpp/src/parquet/arrow/schema_internal.cc#L206 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> See issue. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - `IntoBuffer` for `Vec<T>` where `T` is a Parquet now takes an `ArrowType` arg so we know what to materialize INT96 into. - `ArrowType` metadata in Parquet can now specify the resolution. Alternatively, a `supplied_schema` to `ArrowReaderOptions` can achieve the same effect, which is how DataFusion will pass schema hints for INT96 (similar to `StringView` optimizations). - Extended the INT96 column reader test to support `ArrowType` hints. # Are there any user-facing changes? https://github.com/apache/arrow-rs/pull/7250#discussion_r1989896320 > BTW despite it being marked `pub` IntoBuffer is not pub as this whole module is private: > > * https://docs.rs/parquet/latest/parquet/?search=IntoBuffer I don't believe so. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please call them out. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
