ndemir commented on issue #7273:
URL: https://github.com/apache/arrow-rs/issues/7273#issuecomment-2723209820

   I am not sending a PR because the performance did not improve.
   Here is the 
[diff](https://github.com/apache/arrow-rs/compare/main...ndemir:ndemir/string-coerce-optimization?expand=1)
 you can see.
   
   Here is what I did:
   - I implemented the changes.
   - I implemented a new test function in `json_writer.rs`, the new test 
function name is `bench_coerce_primitive`.
   - I did benchmark: `main` branch vs that [new 
branch](https://github.com/ndemir/arrow-rs/tree/ndemir/string-coerce-optimization).
   
   The results are not good.
   
   ```
   bench_coerce_primitive  time:   [8.5429 ms 8.6018 ms 8.6619 ms]
                           change: [+3.7518% +4.8659% +5.9167%] (p = 0.00 < 
0.05)
                           Performance has regressed.
   ```
   
   That also made me think that if other similar changes are really 
statistically significant. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to