pitrou commented on code in PR #45763:
URL: https://github.com/apache/arrow/pull/45763#discussion_r1995130066
##########
cpp/src/arrow/compute/kernels/codegen_internal.h:
##########
@@ -988,9 +988,9 @@ struct FailFunctor<VectorKernel::ChunkedExec> {
};
// GD for numeric types (integer and floating point)
-template <template <typename...> class Generator, typename Type0,
- typename KernelType = ArrayKernelExec, typename... Args>
-KernelType GenerateNumeric(detail::GetTypeId get_id) {
+template <template <typename...> class Generator, typename Type0, typename...
Args>
Review Comment:
Hmm, you're right that other generators also have an optional `KernelType`
parameter. I could either refactor them all in this PR, or refactor them all in
a separate PR (the former would be easier).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
