raulcd commented on code in PR #45762:
URL: https://github.com/apache/arrow/pull/45762#discussion_r1995438641
##########
cpp/src/arrow/compute/kernels/aggregate_test.cc:
##########
@@ -3693,6 +3693,11 @@ TEST_F(TestSkewKurtosis, Options) {
AssertSkewKurtosisInvalid(type, {"[]", "[]", "[]"}, options);
AssertSkewKurtosisAre(type, "[0, 1, null, 2]", options, 0.0, -1.5);
AssertSkewKurtosisAre(type, {"[0, 1]", "[]", "[null, 2]"}, options, 0.0,
-1.5);
+ options.bias = false;
+ AssertSkewKurtosisAre(type, {"[0, 1]", "[]", "[null, 2]"}, options, 0.0,
NAN);
Review Comment:
I am checking there are enough samples for Skew and Kurtosis same as we do
with `min_count` both on `aggregate` and `hash_aggregate` , I suppose this is
what you meant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
