zanmato1984 commented on PR #45789: URL: https://github.com/apache/arrow/pull/45789#issuecomment-2728239734
> Can we also makes `Segmenter::GetSegments` a const fn? (Or I can do it in a separate patch ) I guess not. Both `SimpleKeySegmenter::GetSegments` and `AnyKeysSegmenter::GetSegments` store intermediate state (that is used for getting the segments from the subsequent batch): https://github.com/apache/arrow/blob/7e18764e1f0ce7afddb169863b6b2b35d26b75b2/cpp/src/arrow/compute/row/grouper.cc#L163 https://github.com/apache/arrow/blob/7e18764e1f0ce7afddb169863b6b2b35d26b75b2/cpp/src/arrow/compute/row/grouper.cc#L273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
