eli-schwartz commented on code in PR #45858:
URL: https://github.com/apache/arrow/pull/45858#discussion_r2002187650
##########
ci/scripts/cpp_build.sh:
##########
@@ -118,12 +118,20 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
}
+ ORIGINAL_CXX=${CXX}
+ if [ "${ARROW_USE_CCACHE}" == "ON" ]; then
Review Comment:
Nit: elsewhere in this file, a single equals sign is used. The script
shebang uses GNU Bash, rather than `/bin/sh`, so this silently works anyway,
but `[` is a POSIX utility and differs from Bash-specific `[[`.
The POSIX definition of `[` does not accept `==`. Even GNU Bash only
supports `==` as doing the same thing as `=`. It is literally "you can spell it
either way, in case you want to". Zero semantic difference between the two, so
I would simply use a single equals everywhere.
...
I think it's terrible that bash supports it, personally -- the only use case
I have ever seen for `==` is for:
> Yeah, so, I'd like to intentionally write scripts that wreck my ability to
remember what works in /bin/sh scripts, so that on the occasion I need to write
/bin/sh scripts my muscle memory has me accidentally writing bashisms that fail
in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
