zanmato1984 commented on code in PR #45789: URL: https://github.com/apache/arrow/pull/45789#discussion_r2003504949
########## cpp/src/arrow/acero/aggregate_internal.h: ########## @@ -143,11 +143,10 @@ Status HandleSegments(RowSegmenter* segmenter, const ExecBatch& batch, } /// @brief Extract values of segment keys from a segment batch -/// @param[out] values_ptr Vector to store the extracted segment key values +/// @param[out] values Vector to store the extracted segment key values /// @param[in] input_batch Segment batch. Must have the a constant value for segment key /// @param[in] field_ids Segment key field ids -Status ExtractSegmenterValues(std::vector<Datum>* values_ptr, - const ExecBatch& input_batch, +Status ExtractSegmenterValues(std::vector<Datum>& values, const ExecBatch& input_batch, Review Comment: Oops, didn't realize this is by coding convention. Updated. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
