H-Plus-Time commented on PR #7310: URL: https://github.com/apache/arrow-rs/pull/7310#issuecomment-2736416512
Also, two things: 1. The bump of the url crate (to 2.5.3) is required for wasip2 to compile (with or without the http feature). I'll remove it from this PR given it falls foul of the stated MSRV 1.64 (especially given there's no wasi client implementation anyway). This does mean though that any default wasi http client (wasip1 will likely _never_ work) would need to bump the MSRV to 1.67 (looks like that'll be fine given the discussion in https://github.com/apache/arrow-rs/issues/181). 2. For 3rd party HttpConnector implementations, the `ClientOptions` struct will need default_headers accessible (in some form, presumably through `get_config_value`, though that does convert to a string. Perhaps just a pub field) outside this crate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
