arashandishgar commented on issue #45808: URL: https://github.com/apache/arrow/issues/45808#issuecomment-2744268013
> ``` > ~/code/arrow (main)$ ag "\bdetail\b" -l | egrep "\.h$" | wc -l > 46 > ``` I evaluate every file which appears by this command and I found the following [reuslt](https://docs.google.com/spreadsheets/d/1Eo8COdoUDs__tYJX-jTdZOGnN-6xfbXu/edit?usp=sharing&ouid=104838600960787304695&rtpof=true&sd=true); I categorised the result into the groups of Yes, No, No*, No**,-,-- 1. **Yes**: the symbol is declared inside detail ns in a header file and only used in its files or just in one .cc file(except test file), I consider the detail namespace as an alternative for anonymous 2. **NO**: The symbol is declared inside detail in a header file but used in multiple .cc files (I write the third column which symblos leads to this state?) 3. **NO***: The symbol is declared inside detail in a header file, but it is used in other header files 4. **NO****: The symbol is declared inside detail in a header file and used inside a test file. 5. **-**: No detail namespace is declared 6. **--**: The file is irrelevant to the discussion. The overall result is: Yes:19 files No:4 files No*:4 files NO**: 1 file -:14 --:3 I think it is possible to consider NO* and NO** as an Alternative for anonymous namespace and it seems the overall rule with some exceptions is that detail namespace is just an alternative for anonymous namespace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
